voxpupuli / puppet-augeasproviders_grub

Augeas-based grub type and providers
Apache License 2.0
9 stars 33 forks source link

Documentation should be more specific about actions taken #33

Closed ggeldenhuis closed 3 years ago

ggeldenhuis commented 6 years ago

It is not 100% clear from the documentation whether the provider also actually runds grub2-mkconfig after setting/changing settings. It could be argued that it is obvious but for the sake of clarity it would be useful if the documentation could specifically say that grub2-mkconfig is run after setting a value. I looked through the code and that is indeed what happens. I am happy to do a tiny PR for the doc update if there is agreement.

kenyon commented 3 years ago

Looks like a duplicate of #40.

raphink commented 3 years ago

Thanks @kenyon