voxpupuli / puppet-augeasproviders_grub

Augeas-based grub type and providers
Apache License 2.0
9 stars 33 forks source link

The grub2 system should update both the EFI and non-EFI configurations when triggered #37

Closed trevor-vaughan closed 4 years ago

trevor-vaughan commented 6 years ago

This was an oversight in my original implementation but systems that can booth either EFI or legacy will potentially switch between the two at will.

This means that both configuration paths need to be updated.

At this point, I'm thinking that it may be best to update all non-symlink copies of target grub configuration files on the system so that random changes don't surprise us in the future but would like some feedback on this idea.

m-morrone commented 6 years ago

This would address an issue I had where the EFI grub2.cfg file was updated but legacy, which was being used, was not.

How often are people switching between the two and if they are do they expect an identical environment? An alternative could be to determine the current boot configuration and only update the grub2.cfg associated with that environment.

trevor-vaughan commented 6 years ago

@m-morrone The issue is that users can randomly select their boot mode. So even if you're in EFI mode, you might decide to use Legacy mode at next boot and end up not applying your expected settings.