Can the call to grub2-mkconfig be disableable?

[tparkercbn]

I use augeasproviders_grub to configure flash card images that contain a configured operating system including /etc/default/grub but that do not have grub or /boot/grub2/grub.cfg yet. That gets installed at burn time when the OS image is actually written to disk.

Would it be possible to add an option to disable the execution of the grub2-mkconfig step so that I can have it skipped when running in my build containers?

Thank you

[trevor-vaughan]

@tparkercbn Seems like a reasonable request. Not sure when anyone can get around to it but it's actually not a very big change.

Happy to point you to the code bits if you're up for working on it.

[tparkercbn]

I'll give it a shot and submit a pull request.

The ruby and puppet code won't be a problem, where I run into issues is rspec tests.

Tom

Get Outlook for Androidhttps://aka.ms/ghei36

---

From: Trevor Vaughan notifications@github.com Sent: Friday, August 16, 2019 4:06:47 PM To: hercules-team/augeasproviders_grub augeasproviders_grub@noreply.github.com Cc: Tom Parker tparker@cbnco.com; Mention mention@noreply.github.com Subject: Re: [hercules-team/augeasproviders_grub] Can the call to grub2-mkconfig be disableable? (#47)

@tparkercbnhttps://github.com/tparkercbn Seems like a reasonable request. Not sure when anyone can get around to it but it's actually not a very big change.

Happy to point you to the code bits if you're up for working on it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/hercules-team/augeasproviders_grub/issues/47?email_source=notifications&email_token=ABJYF5WVLI3W5R3Z5CUEOU3QE4CFPA5CNFSM4IMMNA72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4PSONQ#issuecomment-522135350, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABJYF5QI3GQO6GWOCK54I2TQE4CFPANCNFSM4IMMNA7Q.

[trevor-vaughan]

@tparkercbn That works. Just get things working and someone can help with the tests.