Call grub2-mkconfig on all targets

voxpupuli / puppet-augeasproviders_grub

Augeas-based grub type and providers

Apache License 2.0

9 stars 33 forks source link

Call grub2-mkconfig on all targets #57

Closed traylenator closed 4 years ago

traylenator commented 4 years ago

Currently grub2-mkconfig is called on the first file that exists from.

"/etc/grub2-efi.cfg",
"/boot/efi/EFI/#{os_name.downcase}/grub.cfg",
"/boot/grub2/grub.cfg",
"/boot/grub/grub.cfg"

So on a CentOS 7 system grub2-efi.cfg is generated only from /etc/default/grub.

With an EFI system configured for bios boot the /boot/grub2/grub.cfg is the important one so kernel_parameter updates are not applied.

Taking inspiration from new-kernel-pkg to see what happens on kernel upgrade grubby is called for each of these files that exists so emulating this logic make sense.

Fixes #4

coveralls commented 4 years ago

Coverage remained the same at 95.402% when pulling 2beb5ed326de7e9e7c554f20a7c16a66eceddc11 on traylenator:bios into eb5c38e55510bcb854ca245e086c09975d5d74bc on hercules-team:master.

traylenator commented 4 years ago

If you can give me a hint at what is missing for the coveralls happy to have ago.

trevor-vaughan commented 4 years ago

@traylenator Don't worry about minor coveralls issues. I'll try to take a look at this today. It's been a pain trying to get this right across the board.

traylenator commented 4 years ago

For interest some back ground that led to this:

https://techblog.web.cern.ch/techblog/post/bios_uefi_cloud_image/

jhoblitt commented 2 years ago

I'm labeling this as backwards-incompatible as this has the potential to break the boot config when this module starts doing what it was supposed to be doing.