search

voxpupuli / puppet-augeasproviders_grub

Augeas-based grub type and providers
Apache License 2.0
9 stars 33 forks source link

modulesync 5.3.0 #66

Closed bastelfreak closed 2 years ago

bastelfreak commented 2 years ago

modulesync 5.2.0

jhoblitt commented 2 years ago

@bastelfreak The log for why the workflow failed is gone and I don't have permission to restart the action. Help?

kenyon commented 2 years ago

Updating the commits in the pull request or closing and reopening it will rerun the actions.

jhoblitt commented 2 years ago

I didn't want to monkey with Tim's branch unnecessarily... the brute force approach works... thanks.

kenyon commented 2 years ago

modulesync branches are generally community efforts, feel free to push fixes to them.

ekohl commented 2 years ago

I took the liberty of rebasing this using the latest modulesync master. Now it's clean after modulesync runs.

Looking at CI we can probably also drop Ubuntu 14.04 and 16.04 since they're EOL, but that can also happen after this PR.

ekohl commented 2 years ago

I did some more changes to get the tests to run properly under Docker. I also dropped Grub < 2 support since that simplified the acceptance tests (no need to specify roles).

ekohl commented 2 years ago

I think it's now failing because grub isn't installed in the container images by default and there's no code to do so. That probably needs to be fixed in the acceptance helper for containers. The tests do pass when I use vagrant_libvirt and centos8-64 as a box.

jhoblitt commented 2 years ago

Debian/Ubuntu/Centos all seem to be using grub2 as the package name.

ekohl commented 2 years ago

I'm not sure we can really get grub to work in containers. Should we just stick to unit tests for now?

jhoblitt commented 2 years ago

It looks like github actions support virtualbox under macos but not linux. https://github.com/actions/virtual-environments/issues/114

I suppose we could try to get vagrant working under macos but it probably wouldn't be much fun.

I am fine with merging this with unit tests only.

ekohl commented 2 years ago

Rebased and updated to modulesync config 5.3.0. This now disables acceptance tests in CI. I'm still worried that I think the Debian-based tests don't pass (they need grubby which is a RH-only thing). However, I already spent enough time on a module I don't have a need for ;)

jhoblitt commented 2 years ago 
The workflow is not valid. .github/workflows/ci.yml (Line: 19, Col: 27): Invalid input, pidfile_workaround is not defined in the referenced workflow.
ekohl commented 2 years ago

It is green now. Should we merge it?

jhoblitt commented 2 years ago

Yes ;)