Confine GRUB providers to presence of menus, prefer GRUB 2

voxpupuli / puppet-augeasproviders_grub

Augeas-based grub type and providers

Apache License 2.0

9 stars 33 forks source link

Confine GRUB providers to presence of menus, prefer GRUB 2 #8

Closed ckoenig closed 8 years ago

ckoenig commented 9 years ago

This pull request is based on https://github.com/hercules-team/augeasproviders_grub/pull/1 and the latest comment by @m4ce. The specs are still working.

ckoenig commented 9 years ago

I added two commits incorporating your feedback. Thanks.

raphink commented 9 years ago

@domcleal what do you think of this PR?

raphink commented 8 years ago

@domcleal ?

domcleal commented 8 years ago

Seems reasonable I guess.

coveralls commented 8 years ago

Coverage decreased (-3.7%) to 96.319% when pulling 14b2d1b816cac20fdbba365668902a94ce03e000 on crealytics:confine2 into 980c92116c4164ad470a26330b32b83a97a7c769 on hercules-team:master.

ckoenig commented 8 years ago

To be honest, I'm not sure, what to do about the failing builds in travis. Looks like it tries to install a wrong rake version. Should I rebase by branch on the current master or is the problem something else?

bastelfreak commented 8 years ago

Some of the gems do not work on ruby 1.8.3 in their latest version. there were some changes in the Gemfile that may get them working again.

Or would it be possible to get this merged without without passing tests on 1.8.3? Everything else is green. This would probably fix my issue in https://github.com/hercules-team/augeasproviders_grub/issues/22

raphink commented 8 years ago

https://github.com/hercules-team/augeasproviders_grub/commit/0d8f4455d4278b02abd2c5dca772eaf1fa637fe5 fixes build on Ruby 1.8, so a rebase should pass now.

coveralls commented 8 years ago

Coverage increased (+0.09%) to 96.319% when pulling 08090dc888c4ddd34fc9875ae8b5fa50fcf9b4ed on crealytics:confine2 into 0d8f4455d4278b02abd2c5dca772eaf1fa637fe5 on hercules-team:master.