Closed ckoenig closed 8 years ago
I added two commits incorporating your feedback. Thanks.
@domcleal what do you think of this PR?
@domcleal ?
Seems reasonable I guess.
To be honest, I'm not sure, what to do about the failing builds in travis. Looks like it tries to install a wrong rake version. Should I rebase by branch on the current master or is the problem something else?
Some of the gems do not work on ruby 1.8.3 in their latest version. there were some changes in the Gemfile that may get them working again.
Or would it be possible to get this merged without without passing tests on 1.8.3? Everything else is green. This would probably fix my issue in https://github.com/hercules-team/augeasproviders_grub/issues/22
https://github.com/hercules-team/augeasproviders_grub/commit/0d8f4455d4278b02abd2c5dca772eaf1fa637fe5 fixes build on Ruby 1.8, so a rebase should pass now.
This pull request is based on https://github.com/hercules-team/augeasproviders_grub/pull/1 and the latest comment by @m4ce. The specs are still working.