search

voxpupuli / puppet-augeasproviders_pam

Augeas-based PAM type and provider for Puppet
Other
5 stars 21 forks source link

Puppet 4 support #15

Closed sknolin closed 8 years ago

sknolin commented 8 years ago

Are there plans to make this compatible with Puppet 4.x?

raphink commented 8 years ago

@sknolin how is it not compatible with Puppet 4?

sknolin commented 8 years ago

I just read this - https://forge.puppet.com/herculesteam/augeasproviders_pam/compatibility

Version 2.1.0 is compatible with:

Puppet Enterprise 3.8.x, 3.7.x, 3.3.x, 3.2.x, 3.1.x Puppet >= 2.7.0 < 4.0.0

Maybe this issue should just be 'update forge compatibility page' is all then? :)

raphink commented 8 years ago

Ah well, I think we haven't updated it since Puppet 4 came out.

raphink commented 8 years ago

Actually, puppet_version is deprecated in metadata.json according to docs. @domcleal would you like to remove that info altogether?

domcleal commented 8 years ago

Only "puppet_version" was deprecated, the "requirements" key (containing another list of Puppet versions) is still expected and should include 4.x if the module's indeed tested and works with it.

raphink commented 8 years ago

Ah, right. So I'll remove the puppet_version sections and update the requirements to go up to 4.5. Good for you?

raphink commented 8 years ago

Or maybe < 5.0.0

domcleal commented 8 years ago

Yeah, sounds good. I'd go for < 5.0.0 as Puppet's pretty good at keeping compatibility nowadays, and this is just a regular type/provider.

raphink commented 8 years ago

I might as well update Ubuntu supported versions, too. It changes every 6 months, to ;-)

sknolin commented 8 years ago

Is the forge not linked to metadata.json in the source? Or does it just show up whenever you push a new version out? I tend to just look at that anyhow, but gets confusing.

raphink commented 8 years ago

The forge info is only updated when a new release is pushed.