search

voxpupuli / puppet-augeasproviders_sysctl

Augeas-based sysctl type and provider for Puppet
Apache License 2.0
10 stars 36 forks source link

Update module metadata after transfer to Voxpupuli #69

Closed isc-lindensc closed 1 year ago

isc-lindensc commented 2 years ago

fix metadata - dependency and location referenced

ekohl commented 2 years ago

I think https://github.com/voxpupuli/puppet-augeasproviders_sysctl/pull/65 is intended to really make it a VP module.

deric commented 1 year ago

Please merge this and release with a new puppet-augeasproviders_sysctl version with tag, e.g. 3.0.0 so that other modules can update their dependencies. The existence of puppet-augeasproviders_core module while no module puppet-augeasproviders_sysctl exists, is confusing.

ekohl commented 1 year ago

I've updated #65 to include your change. Somehow idempotency appears broken with Puppet 7 in one specific case, which I don't understand yet.

ekohl commented 1 year ago

I am stuck on https://github.com/voxpupuli/puppet-augeasproviders_sysctl/pull/65#issuecomment-1423868243 and really hesitant to merge something broken. Note that on your PR no CI ran at all, so it may look green but it just didn't test anything.

jcpunk commented 1 year ago

It looks like Augeas 1.14 has some fixes for the sysctl lense, I wonder if that is relevant?

deric commented 1 year ago

@jcpunk The current issues with failing tests isn't probably related to changes in Augeas. This PR probably won't affect this module. I haven't seen any breaking changes, and the augeas package usually installed from OS package, right?

h-haaks commented 1 year ago

@isc-lindensc could you please rebase this against master now that #65 is merged?

h-haaks commented 1 year ago

@isc-lindensc I'll close this PR since there is no more changes to apply.