search

voxpupuli / puppet-blacksmith

Ruby Gem with Puppet Module utilities
Apache License 2.0
69 stars 31 forks source link

Remove oauth username/password login #104

Closed binford2k closed 1 year ago

binford2k commented 2 years ago

This method for logging in to the Forge API is unsupported and not guaranteed to remain stable. We should instruct users to generte an API key instead.

codecov[bot] commented 2 years ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.26 :warning:

Comparison is base (bb45a42) 48.38% compared to head (41f6273) 47.13%.

:exclamation: Current head 41f6273 differs from pull request most recent head fa6e5c4. Consider uploading reports for the commit fa6e5c4 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #104 +/- ## ========================================== - Coverage 48.38% 47.13% -1.26% ========================================== Files 8 8 Lines 465 454 -11 ========================================== - Hits 225 214 -11 Misses 240 240 ``` | [Impacted Files](https://app.codecov.io/gh/voxpupuli/puppet-blacksmith/pull/104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli) | Coverage Δ | | |---|---|---| | [lib/puppet\_blacksmith/forge.rb](https://app.codecov.io/gh/voxpupuli/puppet-blacksmith/pull/104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL3B1cHBldF9ibGFja3NtaXRoL2ZvcmdlLnJi) | `79.54% <100.00%> (-2.28%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ekohl commented 2 years ago

Should we consider this a major version bump?

bastelfreak commented 2 years ago

I also think it is a major change. @binford2k can you take a look at the merge conflict?

binford2k commented 2 years ago

tbh, I'm not convinced that we should move this quickly. Should we deprecate with warning first? Do we have any way to know how many people use it?

Let me see if we can monitor the /oauth/token endpoint and see how many requests have a Blacksmith user agent header.

binford2k commented 2 years ago

looks like we've had zero hits from Blacksmith in the last 30 days. Maybe I'm being overly cautious?

binford2k commented 1 year ago

@bastelfreak I don't know what to do about the remaining rubocop

bastelfreak commented 1 year ago

I merged this in https://github.com/voxpupuli/puppet-blacksmith/pull/119