Closed bastelfreak closed 1 year ago
Patch coverage: 42.85
% and project coverage change: -1.38
:warning:
Comparison is base (
c956a2c
) 49.46% compared to head (da98534
) 48.09%.:exclamation: Current head da98534 differs from pull request most recent head c972900. Consider uploading reports for the commit c972900 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Do we have to be this aggressive? Whilst the latest rubocop still supports Ruby 2.5, do we gain anything by dropping more than just 2.4?
We need to drop Ruby 2.5 in some of the beaker tooling in order to support ruby 3.2. So I reverse the question: what do we gain by not dropping Ruby 2.5 here? Our pipeline won't support Ruby 2.5 anyways. And the actual release is using Ruby 3.0 since a long long time. That's the only scenario where puppet-blacksmith is used.
And if we drop Ruby < 2.6 here we can use the same rubocop configuration as for beaker and other tools we have, and don't maintain multiple configs/CI matrixes.
Also contains #110