search

voxpupuli / puppet-blacksmith

Ruby Gem with Puppet Module utilities
Apache License 2.0
69 stars 31 forks source link

Tasks involving git commands fail if the project path has withspaces #44

Closed rtib closed 7 years ago

rtib commented 7 years ago

If you have a project cloned to a path which somewhere include a directory name having e.g. a space, many git commands issued by blacksmith tasks will fail.

E.g. ` $ rake module:tag rake aborted! Blacksmith::Error: Command git --git-dir=/Users/trepasi/git/GitHub Projects/puppet-zookeeperd/.git --work-tree=/Users/trepasi/git/GitHub Projects/puppet-zookeeperd tag v2.1.0 failed with exit status pid 23102 exit 1 git: 'Projects/puppet-zookeeperd/.git' is not a git command. See 'git --help'.

Tasks: TOP => module:tag `

Presumably https://github.com/voxpupuli/puppet-blacksmith/blob/ad887f17d1e9d2296318cce1e4337423330e81f7/lib/puppet_blacksmith/git.rb#L37 is missing some path quoting.