Use data in modules, instead of params.pp

voxpupuli / puppet-caddy

Puppet Caddy module

MIT License

6 stars 12 forks source link

Use data in modules, instead of params.pp #17

Closed dhoppe closed 4 years ago

dhoppe commented 5 years ago

Pull Request (PR) description

This is one of many pull requests:

[x] Use data in modules, instead of params.pp
[ ] Use resource type archive, instead of curl / tar
[ ] Use resource type systemd::unit_file, instead of file / exec resource
[ ] Add support for Debian / Ubuntu, ...
[ ] Refactor unit tests
[ ] Refactor acceptance tests
[ ] Add support for Puppet Strings
[ ] ...

dhoppe commented 5 years ago

I think I dislike the common.yaml file for things that are the same everywhere. If you use static defaults in init.pp you can extract them with puppet-strings and get better docs.

I use common.yaml for some kind of default and additional files for each distro / release as required.

bastelfreak commented 5 years ago

@ekohl what do you think about this? Should data that's equal on all systems stay in the init.pp?

ekohl commented 5 years ago

@bastelfreak I do think so yes. It gives a better result in puppet-strings.

bastelfreak commented 5 years ago

I'm fine with that. I raised https://github.com/voxpupuli/voxpupuli.github.io/pull/189, lets see if it gets consent.

b4ldr commented 5 years ago

I'm fine with that. I raised voxpupuli/voxpupuli.github.io#189, lets see if it gets consent.

just going through backlog, looks like this got consent now (and i agree)