search

voxpupuli / puppet-caddy

Puppet Caddy module
MIT License
6 stars 12 forks source link

Support redhat 8 #27

Closed qs5779 closed 4 years ago

qs5779 commented 4 years ago

Let me begin by saying that I will not be upset if you choose to say no thanks and close this PR. Here are the basic things I have done.

Ran "pdk convert" in module directory. Replaced params manifest with hieradata support to ease addition of new OS support. I plan for ubuntu and debian in the very near future.

Revamped the spec tests to better support mulitple os support.

Added support for Redhat/Centos 8.

Did my best to incorporate the original travis testing into the travis.yml that was much changed by "pdk convert". On the positive side I can now run beaker acceptance tests locally.

ghoneycutt commented 4 years ago

This is a great PR!! Suggest someone else from VP give this a look. It will need a modulesync and maybe some files set to be ignored in the .sync.yml after this is merged in order to get some of the files back to the Vox Pupuli status quo.

qs5779 commented 4 years ago

I am closing this PR and will resubmit if I am able to locally test without the pdk support.