search

voxpupuli / puppet-caddy

Puppet Caddy module
MIT License
6 stars 12 forks source link

Refactor to simplify code #53

Open ghoneycutt opened 4 years ago

ghoneycutt commented 4 years ago

We said goodbye to params.pp and now to say goodbye to all these private classes that just break the code into multiple files without providing real value.

This is just copy/pasting the code back, except where noted in the comments.

vox-pupuli-tasks[bot] commented 4 years ago

Dear @ghoneycutt, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

ghoneycutt commented 4 years ago

@ekohl could you please merge?

ghoneycutt commented 3 years ago

Could I get a +1 on this refactor?

alexjfisher commented 3 years ago

IMO, it’s quite opinionated and would set a precedent to ditch the install, config, service subclass pattern. Not sure I want to go down this route given the current puppet documentation still recommends this approach. https://puppet.com/docs/puppet/7.5/bgtm.html#modules_ntp_example