search

voxpupuli / puppet-caddy

Puppet Caddy module
MIT License
6 stars 12 forks source link

Release 2.0.0 #67

Closed dhoppe closed 4 years ago

dhoppe commented 4 years ago

Fixes #65

ghoneycutt commented 4 years ago

Please merge #53 before doing the release. This way 2.0.0 starts out refactored.

dhoppe commented 4 years ago

Years ago you wanted to do this kind of refactoring with my dhoppe/fail2ban module. Guess what, the install.pp, config.pp and service.pp manifests still exist. I did not like it then and I still do not like it now.

I had a discussion with @ekohl about this yesterday and I am still not convinced. I like the division into install.pp, config.pp and service.pp, because it results in small and clear files. Also I do not have to care about notify or require.

In the last days I have invested a lot of time to standardize this module to some extent. There is still a lot of work to do for Caddy 2 and we can talk about parameters like manage_user, manage_group, manage_install and manage_service, but I will not merge this pull request.