search

voxpupuli / puppet-caddy

Puppet Caddy module
MIT License
6 stars 12 forks source link

Actually fix github #84

Closed AstraLuma closed 1 year ago

AstraLuma commented 1 year ago

https://github.com/voxpupuli/puppet-caddy/pull/76 was incomplete

smortex commented 1 year ago

Hey @AstraLuma!

We just merged some long-waiting PR that fixed a bunch of issues on the module and we now have CI \o/

Do you mind rebasing you changes on top of the master branch:

From your working directory:

git fetch origin         # Download the latest code we have here
git rebase origin/master # "Move" your commits on top of the main branch
git push -f              # Send the changes (-f is required because we re-wrote history)

Thank you!

smortex commented 1 year ago

Fun fact, the module does not detect the source change and the config does not work as expected. Good news is that it is not related to your changes: the module needs some work.

I started to fix this, and will open a PR on top of this one soon™ :unamused:.

AstraLuma commented 1 year ago

If my work is fine and not reducing functionality in any way, can you please merge my one-character fix?

smortex commented 1 year ago

If my work is fine and not reducing functionality in any way, can you please merge my one-character fix?

Let's do this: my WIP is already out of control :stuck_out_tongue_winking_eye:

smortex commented 1 year ago

@AstraLuma I opened a bunch of issues and PR to fix what I saw. Feel free to comment / review: I am not (yet) a user of Caddy and my experience is limited, you may have some relevant insights!

AstraLuma commented 1 year ago

@AstraLuma I opened a bunch of issues and PR to fix what I saw. Feel free to comment / review: I am not (yet) a user of Caddy and my experience is limited, you may have some relevant insights!

Feel free to at me on anything specific.