voxpupuli / puppet-caddy

Puppet Caddy module
MIT License
6 stars 12 forks source link

Remove legacy top-scope syntax #99

Closed smortex closed 9 months ago

smortex commented 9 months ago

The caddy::version parameter is only used when caddy::install_method is "github", but no error was previously raised if the user set a specific version that was ignored, and the resulting configuration was not what the user expected.

In order to avoid confusion, do not default to an outdated version of caddy when installing from GitHub (requiring the user to explicily tell which version they want) and raise an error if a version is set but is ignored.

This should make the module more user-friendly for new users.

smortex commented 9 months ago

Automation failure