search

voxpupuli / puppet-cassandra

Installs Cassandra & DataStax Agent on RHEL/Ubuntu/Debian.
https://forge.puppetlabs.com/puppet/cassandra
Apache License 2.0
13 stars 65 forks source link

Add Ubuntu 18.04 support #443

Closed paulseward closed 5 years ago

paulseward commented 5 years ago

Pull Request (PR) description

Add Ubuntu 18.04 support, the main difference to existing ubuntu support is that openjdk-7-jre-headless isn't readily available on 18.04 without adding extra repos, so I've bumped that to openjdk-8-jre-headless

Unit tests appear to pass ok.

I've attempted to add an acceptance test for ubuntu18.04, based off the 16.04 test, although I'm having difficulty getting any of the acceptance tests to pass locally - even when run against the upstream master, so I think that's a problem with my local setup rather than the tests.

This Pull Request (PR) fixes the following issues

Fixes #441

bastelfreak commented 5 years ago

Hey @paulseward, thanks for the PR! Please have a look at the inline comments I made.

paulseward commented 5 years ago

@bastelfreak Thanks for reviewing! I think I've resolved everything you brought up, let me know if there's anything I missed :)

bastelfreak commented 5 years ago

Thanks!