modulesync 2.9.0 and drop puppet 4

voxpupuli / puppet-cassandra

Installs Cassandra & DataStax Agent on RHEL/Ubuntu/Debian.

https://forge.puppetlabs.com/puppet/cassandra

Apache License 2.0

13 stars 65 forks source link

Closed bastelfreak closed 4 years ago

bastelfreak commented 5 years ago

modulesync 2.7.0

dhoppe commented 5 years ago

These tests must be converted from mocha to rspec-mocks.

alexjfisher commented 5 years ago

@dhoppe IIRC correctly, this wasn't going to be hard to do, just quite boring for this module (loads of instances to change).

Since we're all short on time, I'm fine with using mocha for now (update .sync.yaml and spec_helper.rb)

bastelfreak commented 5 years ago

@alexjfisher are you able to fix the failing spec tests?

vox-pupuli-tasks[bot] commented 4 years ago

Dear @bastelfreak, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

alexjfisher commented 4 years ago

I'll open a fresh PR.

alexjfisher commented 4 years ago

I have a backup of the modulesync branch I've just deleted.