voxpupuli / puppet-cassandra

Installs Cassandra & DataStax Agent on RHEL/Ubuntu/Debian.
https://forge.puppetlabs.com/puppet/cassandra
Apache License 2.0
13 stars 65 forks source link

Bump puppet-firewall version to allow version 2.x #464

Closed waipeng closed 4 years ago

waipeng commented 4 years ago

Pull Request (PR) description

Bump puppet-firewall version to <= 2.5.0

This Pull Request (PR) fixes the following issues

n/a

bastelfreak commented 4 years ago

please rebase after https://github.com/voxpupuli/puppet-cassandra/pull/465, that should fix the linter warnings.

waipeng commented 4 years ago

Thanks for looking at this!

If this is fine to be merged, is it also possible to have a point release containing this?

kowoba commented 4 years ago

Yes please make a point release - puppet-cassandra currently prevents upgrading Debian systems from 9 stretch to 10 buster.

bastelfreak commented 4 years ago

@kowoba do you use the module on debian 9 / 10? If so, could you add a PR that adds support for those? At the moment the metadata.json only lists Debian 8.

kowoba commented 4 years ago

@kowoba do you use the module on debian 9 / 10?

No, I am just here because of "dependency hell" :)

I don't use puppet-cassandra, I just share puppetmasters/servers with some who do, and what version of Debian they are using, I don't know (but I would guess older). My problem is that I have other puppet-modules that rely on newer puppet-firewall (which is required for Debian 10), but I can not upgrade the servers using those, because the current puppet-cassandra module is holding back newer puppet-firewall, for the entire site...

bastelfreak commented 4 years ago

Hi, the new version is online: https://forge.puppet.com/puppet/cassandra