search

voxpupuli / puppet-catalog_diff

📄↔📄 A tool to diff Puppet catalogs
https://forge.puppet.com/modules/puppet/catalog_diff/readme
Apache License 2.0
14 stars 16 forks source link

Reporting for 'failed_nodes' doesn't work #92

Open JoshuaSmeda opened 1 year ago

JoshuaSmeda commented 1 year ago

If you use Catalog Diff Viewer, you might notice that there is a failed selector on custom reports (reports that are generated from Catalog Diff):

Screenshot 2022-11-07 at 15 43 35

The catalog diff face doesn't compute and write the failed_nodes and their tallies to the report file (anymore?)

The default report that gets put down, has failed_nodes set and presents correctly on the front end. You can find an example here: Catalog Diff Viewer Demo Report

I would like the failed_nodes functionality to be implemented so that I'm able to fully utilize the front end (Viewer) as intended without relying on the stdout of the Catalog Diff to know if there is an error.

vchepkov commented 11 months ago

I noticed the same issue. File created using output_report argument doesn't include pull_output :

  "pull_output": {
    "failed_nodes": {
  ...