search

voxpupuli / puppet-collectd

Collectd module for Puppet
https://forge.puppet.com/puppet/collectd
Apache License 2.0
69 stars 272 forks source link

ValuesFrom in postgresql query.conf should allow multiple values #1009

Closed markasammut closed 1 year ago

markasammut commented 1 year ago

Pull Request (PR) description

ValuesFrom in postgresql query.conf should allow an array of multiple values, not just a single value, as per documentation: https://collectd.org/documentation/manpages/collectd.conf.5.shtml#query_blocks

This Pull Request (PR) fixes the following issues

Issue is not documented yet

markasammut commented 1 year ago

Suggestions committed - removed extra line repeating the ValuesFrom

bastelfreak commented 1 year ago

@markasammut thanks for the PR. can you please add a unit test for it?

markasammut commented 1 year ago

Never really mastered writing one, but will try.

markasammut commented 1 year ago

@bastelfreak modified spec file to test accepting an arrray - 1 CentOS8 check is failing but I don't believe it's related to this change.