search

voxpupuli / puppet-collectd

Collectd module for Puppet
https://forge.puppet.com/puppet/collectd
Apache License 2.0
69 stars 272 forks source link

Add write_graphite options introduced in collectd 5.7.0 #1014

Closed gerases closed 1 year ago

gerases commented 1 year ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

gerases commented 1 year ago

I'm still working on this branch, it's work in progress

smortex commented 1 year ago

The PR title says 5.8 but the code says 5.7…

I'm still working on this branch, it's work in progress

Is it still the case? FYI, you can make this PR a draft while you are working on it (top of the menu on right), so that maintainers know that it is being worked on an then turn it back to the "ready for rewiew" state when you are ready :wink:

gerases commented 1 year ago

Thanks for the tip on coverting the PR to a "draft". About 5.8, yes, originally I thought it was 5.8 but after more research I realized it was 5.7 as far as the collectd github code is concerned. But it's possible the RPM where it was first introduced was 5.8. Still researching that part.

gerases commented 1 year ago

Hi @smortex, what does the ETA for merging this look like? Just curious.

smortex commented 1 year ago

I like to let other people double-check areas I am not familiar with, but after a week I think we can safely merge it.

gerases commented 1 year ago

Sounds good, thank you