voxpupuli / puppet-collectd

Collectd module for Puppet
https://forge.puppet.com/puppet/collectd
Apache License 2.0
69 stars 272 forks source link

Complains about dependencies. #691

Open gl00ten opened 6 years ago

gl00ten commented 6 years ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

What are you seeing

Makes puppet complain about depencies.

lontra@HP-Z230:~/repos/operacoes-puppet/modules$ puppet module list --modulepath .
/home/lontra/repos/operacoes-puppet/modules
├── adrien-alternatives (v0.3.0)
├── ghoneycutt-hosts (v2.5.0)
├── pcfens-filebeat (v1.0.0)
├── puppet-archive (v1.3.0)
├── puppet-nginx (v0.6.0)
├── puppet-yum (v2.0.0)
├── puppetlabs-apache (v1.11.0)
├── puppetlabs-apt (v2.4.0)
├── puppetlabs-concat (v2.2.1)
├── puppetlabs-motd (v1.4.0)
├── puppetlabs-powershell (v2.1.1)
├── puppetlabs-registry (v1.1.4)
├── puppetlabs-stdlib (v4.19.0)
├── rodjek-logrotate (v1.1.1)
└── sapo_facts (???)
lontra@HP-Z230:~/repos/operacoes-puppet/modules$ 
lontra@HP-Z230:~/repos/operacoes-puppet/modules$ 
lontra@HP-Z230:~/repos/operacoes-puppet/modules$ 
lontra@HP-Z230:~/repos/operacoes-puppet/modules$ puppet module install puppet-collectd  --modulepath .Notice: Preparing to install into /home/lontra/repos/operacoes-puppet/modules ...
Notice: Downloading from https://forgeapi.puppetlabs.com ...
Notice: Installing -- do not interrupt ...
/home/lontra/repos/operacoes-puppet/modules
└─┬ puppet-collectd (v5.2.0)
  ├── puppet-yum (v2.0.0)
  ├── puppetlabs-apt (v2.4.0)
  ├── puppetlabs-concat (v2.2.1)
  └── puppetlabs-stdlib (v4.19.0)
lontra@HP-Z230:~/repos/operacoes-puppet/modules$ 
lontra@HP-Z230:~/repos/operacoes-puppet/modules$ 
lontra@HP-Z230:~/repos/operacoes-puppet/modules$ puppet module list --modulepath .
Warning: Missing dependency 'puppet-yum':
  'puppet-collectd' (v5.2.0) requires 'puppet-yum' (>= 0.9.15)
Warning: Missing dependency 'puppetlabs-apt':
  'puppet-collectd' (v5.2.0) requires 'puppetlabs-apt' (>= 2.2.0)
/home/lontra/repos/operacoes-puppet/modules
├── adrien-alternatives (v0.3.0)
├── ghoneycutt-hosts (v2.5.0)
├── pcfens-filebeat (v1.0.0)
├── puppet-archive (v1.3.0)
├── puppet-collectd (v5.2.0)
├── puppet-nginx (v0.6.0)
├── puppet-yum (v2.0.0)
├── puppetlabs-apache (v1.11.0)
├── puppetlabs-apt (v2.4.0)
├── puppetlabs-concat (v2.2.1)
├── puppetlabs-motd (v1.4.0)
├── puppetlabs-powershell (v2.1.1)
├── puppetlabs-registry (v1.1.4)
├── puppetlabs-stdlib (v4.19.0)
├── rodjek-logrotate (v1.1.1)
└── sapo_facts (???)
lontra@HP-Z230:~/repos/operacoes-puppet/modules$ 

What behaviour did you expect instead

Output log

Any additional information you'd like to impart

juniorsysadmin commented 6 years ago

Seems like a problem that would be solved if this module used soft dependencies: https://docs.puppet.com/puppet/latest/style_guide.html#dependencies