search

voxpupuli / puppet-confluence

A puppet module to install confluence
https://forge.puppet.com/puppet/confluence
MIT License
21 stars 76 forks source link

Issue 119: updated facter script to not report java version #121

Closed senax closed 7 years ago

senax commented 7 years ago

The facter script was reporting the java version instead of the confluence version. Looking for the first thing on the ps line which looks like a version is not ideal.

Unfortunately the rest API does not seem to provide a version. Jira does; Atlassian are very inconsistent.

This change simply improves on the string matching on the ps line a bit.

This stopped our server from trying to 'upgrade' from 1.8.0 (java version) to 6.0.x.

bastelfreak commented 7 years ago

Can you please rebase against master? https://github.com/voxpupuli/puppet-confluence/pull/120 and https://github.com/voxpupuli/puppet-confluence/pull/122 got merged. Then travis should be green again.

senax commented 7 years ago

Ended up with a new fork, will close and create new pull request.