voxpupuli / puppet-confluence

A puppet module to install confluence
https://forge.puppet.com/puppet/confluence
MIT License
21 stars 76 forks source link

Update setenv.sh to support CATALINA_OPTS #167

Closed TJM closed 6 years ago

TJM commented 6 years ago

Pull Request (PR) description

Updates to setenv.sh support CATALINA_OPTS

* Continuation of PR #140 (@joshbeard)
* Support CATALINA_OPTS either as a string or array of strings
* These changes should support making the setenv.sh with minimal changes
    from 6.0.x (which is EOL soon) to 6.12.x which was just released.
* Change so the "JAVA_OPTS" part only appear for version prior to Confluence 5.x
* Update README for types and to have an example

This Pull Request (PR) fixes the following issues

TJM commented 6 years ago

sorry, took me a few tries to get the rspec part done. It is still not 100% on the template, but at least I am testing for the catalina_opts parameter

bastelfreak commented 6 years ago

Thanks @TJM !