search

voxpupuli / puppet-confluence

A puppet module to install confluence
https://forge.puppet.com/puppet/confluence
MIT License
21 stars 76 forks source link

drop dependency on camptocamp/systemd #173

Closed fraenki closed 5 years ago

fraenki commented 5 years ago

Pull Request (PR) description

Currently this module depends on camptocamp/systemd, but it's only used for a single call to systemctl. A downside of using this dependency is that it may conflict with other systemd modules.

This PR replaces the need for camptocamp/systemd with a simple Exec.

bastelfreak commented 5 years ago

Hi @fraenki. In the past we agreed on adding the dependency so we don't have to define the exec resource in each module, so this is actually on purpose. Does the resource from the systemd module conflict with another module?

fraenki commented 5 years ago

Does the resource from the systemd module conflict with another module?

The problem is that one cannot use two modules with the same name, in this case two modules with the name systemd.

The dependency on camptocamp/systemd forces users to either use camptocamp/systemd for their systemd-related needs or to ignore the module's dependencies and workaround this locally (which is a bad idea).

This module doesn't really need all the features that camptocamp/systemd offers, it could easily be replaced, hence my proposal.

bastelfreak commented 5 years ago

yes, namespacing in the puppet ecosystem is a long issue. I still think that the camptocamp/systemd module is the way to go. It is the approved module for systemd, so IMO this and no others should be used. Does it have any missing features? I'm happy to have a look and implement them there. Also I want to replace the ugly file resources for the unit file with the systemd::unit_file resource.

fraenki commented 5 years ago

@bastelfreak Thanks for your answer! Actually yes, the camptocamp/systemd module is missing some features and convenience addons that we heavily depend on and that are present in NTTCom-MS/eyp-systemd. Especially the defined type to handle drop-ins (they use a template, so we don't have to provide our own file for every service) and the possibility to manage logind.conf. I could create feature requests in the camptocamp/systemd issue tracker if you see a chance to get these features implemented.

Dan33l commented 5 years ago

I agree with @bastelfreak. As supported module camptocamp/systemd should be updated instead of reinvent the wheel each time.

Are you able to implement the feature requests ?

bastelfreak commented 5 years ago

I'm not sure if I find the free time in the near future to implement this in the camptocamp/systemd module. It would be awesome if you can provide a PR, I'm happy to review and merge it. Otherwise please open a feature request.