search

voxpupuli / puppet-confluence

A puppet module to install confluence
https://forge.puppet.com/puppet/confluence
MIT License
21 stars 76 forks source link

Debian support #177

Closed rrotter closed 5 years ago

rrotter commented 5 years ago

Pull Request (PR) description

Patch PR 147 to pass unit tests, as a start on supporting Debian 8/9. Default to init.d script for debian systems when systemd is not found, previous PR failed on Ubuntu 14.04 because the behavior for upstart (i.e., it died) was incorrect.

bastelfreak commented 5 years ago

Thanks for the patch! Can you please add Debian to the metadata.json?

rrotter commented 5 years ago

Added Debian 9 to metadata.json.

Sorry for the delay on this, I wanted to be sure that there was nothing else needed to support Debian 9 (there isn't, it works) before making the metadata.json change, and in the meantime the 18.04 patch conflicted with mine.

rrotter commented 5 years ago

And it appears that puppet rspec has issues with using service_provider. Back to the drawing board.