search

voxpupuli / puppet-confluence

A puppet module to install confluence
https://forge.puppet.com/puppet/confluence
MIT License
21 stars 77 forks source link

Fix lint warning #222

Closed h-haaks closed 1 year ago

h-haaks commented 2 years ago

Pull Request (PR) description

Trying to cleanup failing tests

bastelfreak commented 2 years ago

this branch seems to be out of date. can you please rebase against our latest master branch? (this should remove the Puppet 5 CI job).

h-haaks commented 2 years ago

this branch seems to be out of date. can you please rebase against our latest master branch? (this should remove the Puppet 5 CI job).

ref slack earlier to day. I'm just trying to fix #211, that's why my branch is based from the modulesync branch. Wouldn't it be better if the modulesync branch was rebased first then?

h-haaks commented 2 years ago

@bastelfreak do you know how I could run the acceptance test locally? There is no litmus rake tasks available and no beaker node definitions ...

bastelfreak commented 1 year ago

it doesn't look like your branch is based on the modulesync, because the modulesync changes aren't included here. To run the beaker jobs locally, you can do:

BEAKER_destroy=no BEAKER_PUPPET_COLLECTION=puppet7 BEAKER_setfile=centos8-64 BEAKER_HYPERVISOR=vagrant_libvirt bundle exec rake beaker

Instead of vagrant_libvirt, you can also specify beaker. The nodeset will be generated on the fly.

h-haaks commented 1 year ago

The pull request is for voxpupuli:modulesync. That's why there is mo modulesync changes :)

h-haaks commented 1 year ago

I guess I could rebase my branch against master and keep all the changes from the modulesync branch.