search

voxpupuli / puppet-confluence

A puppet module to install confluence
https://forge.puppet.com/puppet/confluence
MIT License
21 stars 76 forks source link

Update based on voxpupuli/modulesync_config #56

Closed dhoppe closed 8 years ago

dhoppe commented 8 years ago

Please merge. I disabled the check variable_contains_upcase until we fixed this and have a better code coverage.

jyaworski commented 8 years ago

Invalid resource types?

dhoppe commented 8 years ago

I do not know, but I will fix this during the weekend. I am pretty sure that puppet-jira will also fail.

dhoppe commented 8 years ago

@jyaworski I think we should remove the tests for deploy and migrate to voxpupuli/archive as @mkrakowitzer did for voxpupuli/stash.

There is a lot to do like implementing class parameters, renaming the parameters (variable_contains_upcase) and implementing more RSpec and Beaker tests.

dhoppe commented 8 years ago

This is failing because the error message does not fit at Puppet 4 and I do not know, why #43 was closed. To me it makes sense to set javahome to undef and throw an error message via fail. This is exactly what we should do for the jira and stash modules, too.