search

voxpupuli / puppet-confluence

A puppet module to install confluence
https://forge.puppet.com/puppet/confluence
MIT License
21 stars 76 forks source link

Release 2.2.1 #71

Closed bastelfreak closed 8 years ago

rnelson0 commented 8 years ago

We shouldn't need to delete .pmtignore to trigger the tag. It may also bloat the package size, which is why it's usually present. Was that issue fixed in the PMT?

bastelfreak commented 8 years ago

the puppet doc says that it honors the .gitignore or .pmtignore. the latter one is preffered if both files are present. travis installs gems into vendor/, our gitignore handles this, but the pmtignore doesn't. these files are redundant, but gitignore is handled by modulesync. .

rnelson0 commented 8 years ago

That's the bug, it wasn't honoring it. If you can replicate what CI does and it's not oversized, go for it, otherwise I'll look up the bug ID tomorrow.

Rob Nelson rnelson0@gmail.com