voxpupuli / puppet-confluence

A puppet module to install confluence
https://forge.puppet.com/puppet/confluence
MIT License
21 stars 76 forks source link

Parameter name in README is wrong #76

Closed circuitousNerd closed 8 years ago

circuitousNerd commented 8 years ago

Affected Puppet, Ruby, OS and module versions/distributions

None. This is a documentation issue

What are you seeing

Complex example shows:

  class { 'confluence':
    version        => '5.7.1',
    installdir     => '/opt/atlassian/atlassian-confluence',
    homedir        => '/opt/atlassian/application-data/confluence-home',
    javahome       => '/opt/java',
    java_opts      => '-Dhttp.proxyHost=proxy.example.com -Dhttp.proxyPort=3128 -Dhttps.proxyHost=secure-proxy.example.com -Dhttps.proxyPort=3128'
    proxy          => {
      scheme       => 'https',
      proxyName    => 'confluence.example.co.za',
      proxyPort    => '443',
    },
  }

What behaviour did you expect instead

Complex example should show:

  class { 'confluence':
    version        => '5.7.1',
    installdir     => '/opt/atlassian/atlassian-confluence',
    homedir        => '/opt/atlassian/application-data/confluence-home',
    javahome       => '/opt/java',
    java_opts      => '-Dhttp.proxyHost=proxy.example.com -Dhttp.proxyPort=3128 -Dhttps.proxyHost=secure-proxy.example.com -Dhttps.proxyPort=3128'
    tomcat_proxy   => {
      scheme       => 'https',
      proxyName    => 'confluence.example.co.za',
      proxyPort    => '443',
    },
  }

How did this behaviour get triggered

Output log

Any additional information you'd like to impart

I have fixed this in a fork but wasn't sure if it was worth making a PR for. If it is, let me know and I'll make it.

bastelfreak commented 8 years ago

thanks for reporting this. Could you please submit the PR?

circuitousNerd commented 8 years ago

Done. Forgive me if I did it incorrectly, this is my first PR.

igalic commented 8 years ago

i think it was quite good :D