voxpupuli / puppet-confluence

A puppet module to install confluence

https://forge.puppet.com/puppet/confluence

MIT License

21 stars 76 forks source link

make facts.sh sh compatible #83

Closed mookie- closed 8 years ago

mookie- commented 8 years ago

[[ are bash builtin and not supported by sh

mookie- commented 8 years ago

82

alexjfisher commented 8 years ago

@mookie- Thanks. Very small nitpick. - spelling of 'compatible' in commit message.

Other than that, the change looks correct (eg $VERSION is correctly quoted, -z is available in posix shells etc) http://mywiki.wooledge.org/BashFAQ/031

mookie- commented 8 years ago

Thanks @alexjfisher I'm sorry. I should have been more careful.

alexjfisher commented 8 years ago

@mookie- No worries. Thanks for your PR and thanks for updating the commit. Merged.