search

voxpupuli / puppet-confluence

A puppet module to install confluence
https://forge.puppet.com/puppet/confluence
MIT License
21 stars 76 forks source link

Make confluence_version a First Class Fact #92

Closed spjmurray closed 8 years ago

spjmurray commented 8 years ago

This stems from the fact that the confluence module unconditionally manages the directory /etc/puppetlabs/facter/facts.d directory in the sense that if the code gets evaluated first you run into the age old race condition of clashing with other classes who wish to manage it. This removes said management, moves the fact to a ruby/puppet native which yields slightly prettier and less code.

The change to confluence::service was required to get CI to pass. I'd properly refactor this but it'd probably destroy users who already reference in hiera confluence::service::service_file_location etc.

spjmurray commented 8 years ago

Also helps with #83 becoming a thing of the past!

dustycodes commented 8 years ago

Any idea when this will be merged?

dhoppe commented 8 years ago

@spjmurray Thx for your contribution.

dhoppe commented 8 years ago

@spjmurray I think you also need to make sure that the old fact confluence_facts.sh does not exist anymore.