search

voxpupuli / puppet-consul

A Puppet Module to Manage Consul
Apache License 2.0
121 stars 315 forks source link

additional arm arch check post version 1.9.10 #599

Closed ikonia closed 1 year ago

ikonia commented 2 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

bastelfreak commented 1 year ago

please also rebase against master to get rid of the merge commits.

ikonia commented 1 year ago

please also rebase against master to get rid of the merge commits.

user error on my part - I'm going to close this PR as it was opened too early, and any changes I make will trigger CI.

I'll make the appropriate changes and rebase and then open a new PR otherwise this will just create noise

kenyon commented 1 year ago

It's really not a problem to trigger CI, that's what it's there for. You can also set the PR as a draft until ready. Fewer PRs is easier when making releases and figuring out what PRs should be in the changelog.