Closed jardleex closed 6 months ago
try running
bundle install
bundle exec rake strings:generate:reference
that should fix the test and get the CI running :)
@jardleex thanks for the PR. We run some acceptance tests in https://github.com/voxpupuli/puppet-consul/blob/master/spec/acceptance/class_spec.rb. Do we need to adjust them for other versions? Does your patch work on older consul versions as well?
Pull Request (PR) description
Hi,
this change replaces the usage of the token query paramter with the HTTP header X-Consul-Token when interacting with ACLs, key/values and prepared queries. The header was introduced in Consul 0.6.0. The change is necessary as the token query parameter is marked deprecated in Consul 1.15.x. Using it triggers deprecation warnings in the Consul logs each time this module runs on a server.
Luckily it was not removed yet so there is still time to fix it. I've tested the changes with our internal Puppet module in Vagrant.
This pull request was created by my best knowladge. I'm working as system administrator and have no ruby expertise but got some help from colleagues in our company. Thus said I'm open for any suggestion to improve this.
Thanks in advance!
This Pull Request (PR) fixes the following issues
n/a.