search

voxpupuli / puppet-corosync

Sets up and manages Corosync.
https://forge.puppet.com/puppet/corosync
Apache License 2.0
44 stars 161 forks source link

Add EL8 support and claim compatibility #527

Open optiz0r opened 2 years ago

optiz0r commented 2 years ago

Pull Request (PR) description

Rework of #484 against latest master branch.

The version of corosync uses a cli parameter instead of an environment variable to point at the config file to be tested. Without this change, the env var is ignored and the config_validate_cmd command always checks the real config file location before installing the candidate file. On a new build, this will fail because the real config file does not yet exist. When being updated, the real config file is checked, instead of the candidate file, so an invalid change might be falsely reported as acceptable and lead to an outage.

This change overrides the config validate command on el8 to use the correct syntax.

It also lists el8 as a compatible OS in the module metadata, since the module is currently being used with this patch in production.

This Pull Request (PR) fixes the following issues

Fixes #526 Obsoletes #484

zilchms commented 5 months ago

@optiz0r , can you rebase on the current master branch?