Closed maartenbeeckmans closed 3 months ago
The other checks failing are with the installation of pacemaker on debian 10/11, which is not something that I touched in this PR
Is there any plan to merge this PR?
@agriffit79 we cannot merge it because the whole pipeline is red, this needs to be fixed first.
The fault isn't with this PR though? The test failures seem to have been introduced in #529 ?
The fault isn't with this PR though? The test failures seem to have been introduced in #529 ?
Yes, this is the reason why the tests are failing, and I have no clue how to fix this. I think it is also out of scope of this PR
The fault isn't with this PR though? The test failures seem to have been introduced in #529 ?
Yes, this is the reason why the tests are failing, and I have no clue how to fix this. I think it is also out of scope of this PR
I submitted #540 which fixes most of the tests, but it's not been merged. Not really clear if this module is still actively maintained by anyone.
@bastelfreak I've rebased, fixed the tests, and regenerated the references. Debian 11 is still failing, but this also seems to be the case in other PRs.
@Vincevrp can you rebase this again please? We just merged other PRs and they had working Debian 11 tests.
@bastelfreak there we go
thanks for all the work!
Add the attributes promotable, promoted_max and promoted_node_max to the cs_clone resource.
The cs_clone resource now contains all options present in the pacemaker documentation: the https://www.clusterlabs.org/pacemaker/doc/2.1/Pacemaker_Explained/singlehtml/index.html#clone-options
Pull Request (PR) description
This pr add the parameters for managing promotable resources again, but now with the cs_clone resource instead of the cs_primary resource after that those were removed in PR #499.
This Pull Request (PR) fixes the following issues
Fixes #523
The required code changes in puppet to apply these changes are the following for managing a Redis Leader Follower cluster
Old setup before #499:
Puppet code after this PR:
This will create a very simular setup, but master/slave has been renamed to promoted/unpromoted in the pacemaker documentation.