search

voxpupuli / puppet-cron

Puppet module to manage cron jobs via /etc/cron.d
https://forge.puppet.com/puppet/cron
Apache License 2.0
14 stars 40 forks source link

Add parameters for file/directory modes #134

Closed ludovicus3 closed 5 months ago

ludovicus3 commented 5 months ago

Some security scans don't like the default file modes set by this module. I have added parameters to allow for the adjustment of the file modes for this ability to resolve this issue per the users desires.

TheMeier commented 5 months ago

Please update REFERENCE.md see https://voxpupuli.org/docs/how_to_run_tests/#referencemd-update

TheMeier commented 5 months ago

IMHO it should only be file_mode and dir_mode

ludovicus3 commented 5 months ago

I don't have any major argument against that other than parameters that refer to the crontab and such are prefixed crontab_ but I could change it if it's preferred.

TheMeier commented 5 months ago

Well what triggerd this comment is that the crontab-prefixed parameters seem to go inside the templated content opposed to any other parameters

TheMeier commented 5 months ago

Ok an excception is crontab_run_parts which is used in the puppet DSL and in the epp