search

voxpupuli / puppet-cron

Puppet module to manage cron jobs via /etc/cron.d
https://forge.puppet.com/puppet/cron
Apache License 2.0
14 stars 40 forks source link

Added option to delete the cron.deny file when $manage_users_deny is true. #146

Open bschonec opened 3 months ago

bschonec commented 3 months ago

Pull Request (PR) description

Ability to manage the existence of /etc/cron.deny. Some CIS audits recommend/require that if no entries are made to /etc/cron.deny then the file should be deleted.

This Pull Request (PR) fixes the following issues

Allows the deletion of /etc/cron.deny.

Reference #145

TheMeier commented 3 months ago

LGTM. Won't approve since I don't use cron anymore :D

bschonec commented 3 months ago

Indeed. Unfortunately, I'm still stuck in the past....

bschonec commented 3 months ago

@TheMeier , are the tests running properly? I see a bunch of "Could not retrieve fact ipaddress" errors.

yakatz commented 3 months ago

ipaddress is a legacy fact - it is no longer generated by default. Any tests that use it need to be updated.

The actual test failures don't appear to be related to that.

bschonec commented 3 months ago

Whoops, I put the management in cron.allow instead of cron.deny. Fixed with this updated branch.