search

voxpupuli / puppet-dhcp

Puppet module for deploying dhcp
https://forge.puppet.com/puppet/dhcp
Apache License 2.0
41 stars 136 forks source link

rename fragments for dhcp6-pools #263

Closed sircubbi closed 2 years ago

sircubbi commented 2 years ago

Pull Request (PR) description

Allow the same resource-title for pool and pool6-definitions

This Pull Request (PR) fixes the following issues

Currently you cannot give a dhcp and dhcp6-pool the same resource-title, since the name would be shared by the concat::fragment. This is quite unexpected, so make sure that we use a different title on the fragments for pool6-defines.

sircubbi commented 2 years ago

Since PR #263 and #261 where separated, there is the need to rename the fragment-title after both branches were merged. Can you add that fix too, or should I open a new PR?

root-expert commented 2 years ago

:facepalm: I didn't thought of that. Yea please open a new PR. Sorry for that!

sircubbi commented 2 years ago

facepalm I didn't thought of that. Yea please open a new PR. Sorry for that!

No problem. Fixed in PR #264