search

voxpupuli / puppet-dropbear

Manage dropbear with puppet
http://forge.puppetlabs.com/puppet/dropbear
GNU General Public License v3.0
0 stars 5 forks source link

takes advantage of some new Puppet language features; require stdlib 4.25 #20

Closed chadh closed 5 years ago

chadh commented 6 years ago

Pull Request (PR) description

This pull request is a first pass at modernizing the dropbear module. It removes the validate_* functions and replaces with Puppet Types, converts to EPP templates, and Hiera 5.

I am obviously new to VP, but I would like to contribute more. I am submitting this mostly just to get my feet wet, so if it is total garbage, feel free to say so ;-) .

It's a larger pull request than I usually like, and I can tear it apart some if you prefer.

The unit tests all pass, but I will be adding some more around the deprecation pieces that I added.

chadh commented 6 years ago

I think the failing check is a false positive (per https://github.com/voxpupuli/puppet-lint-trailing_comma-check/issues/4).

bastelfreak commented 5 years ago

Hi @chadh, are you still interested in getting this merged? If so. please rebase against our latest master branch.

chadh commented 5 years ago

yep! I have rebased on master and fixed up a merge conflict.