Add support for ILM policies and indices

voxpupuli / puppet-elasticsearch

Elasticsearch Puppet module

Apache License 2.0

403 stars 478 forks source link

Add support for ILM policies and indices #1103

Closed joshperry closed 2 years ago

joshperry commented 3 years ago

Trying to upstream this addition to manage ILM policies and indices.

Love some input as I'm not sure if this is the best method to accomplish this. Also, now realize I was working on an old version of this module which didn't have tests so I'm going to need to add those.

Going to need to get my employer to sign the CLA (or assign me copyright so I can).

Fixes: #1038

Pull request acceptance prerequisites:

[ ] Signed the CLA (if not already signed)
[x] Rebased/up-to-date with base branch
[ ] Tests pass
[ ] Updated CHANGELOG.md with patch notes (if necessary)
[ ] Updated CONTRIBUTORS (if attribution is requested)

elasticmachine commented 3 years ago

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

cla-checker-service[bot] commented 3 years ago

❌ Author of the following commits did not sign a Contributor Agreement: bd52bd2f7ec411539d9359fdbfedfc649bd0c462, 3c087b0a2752c5f30663d3ed6de724c0c668b196, 1c1b9e8bcddbdd37b9bdf9db1d14ffbec4368083, 4c56da4be1e0c641d7cc1dbe29859ff2e9a77ef9, 811e5c6ba853574012c2a1287bb8eda98c3799dc, acd090ace4cf83dfb395be75ed0d97155cd090f0, a79731c6e60a3f29777aeffa8546ecc54ffcaa1c, a091138a27f3785ea6fe44f81abe54cc3358544c, 6100f0260f87783cc3e5bd134fc052c583a76a1e, f17624952173383d95113704987d88a05481fc5e

Please, read and sign the above mentioned agreement if you want to contribute to this project

joshperry commented 3 years ago

Paid all my rubocop tickets. I'll work on some tests tomorrow.

fatmcgav commented 3 years ago

@joshperry Thank you for the contribution - This looks like a very good start.

As you say, some tests would be awesome. Also, I've just pushed a load of changes to the master branch, so this will need a rebase/merge :)

Finally, we will need to have a signed CLA before we can accept this contribution.

Thanks again.

mdklapwijk commented 2 years ago

Since Elastic seems to have dropped support and shipped the repositories over to vox-pupuli; any update on this?

ghoneycutt commented 2 years ago

This needs tests to be merged. The minimum would be some acceptance testing.

smortex commented 2 years ago

Close in favor of #1163 (please test this PR and report if working as expected if you can). Thanks!