Do not restart Elasticsearch on config change when restart_config_change is set to false

voxpupuli / puppet-elasticsearch

Elasticsearch Puppet module

Apache License 2.0

403 stars 478 forks source link

Do not restart Elasticsearch on config change when restart_config_change is set to false #1114

Closed scornelissen85 closed 2 years ago

scornelissen85 commented 3 years ago

This change will fix that Elasticsearch service is not being restarted when restart_config_change is set to false. Without this change Elasticsearch was still restarted on config changes even when restart_config_change was set to false. See also issue #1113

elasticmachine commented 3 years ago

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

crazymind1337 commented 3 years ago

@fatmcgav can we have this PR merged and released soon? I dont like to fork the module again for such a tiny issue.

shamil commented 3 years ago

I think https://github.com/elastic/puppet-elasticsearch/pull/1111 is what's needed, no need to globally notify entire class

scornelissen85 commented 3 years ago

I think #1111 is what's needed, no need to globally notify entire class

~If you use that method then Elasticsearch will never restart after a config change, is it?~

Never mind, I see it's notifying the service from each resource in elasticsearch::config only if restart_config_change is set true.