Add option to set private key type

voxpupuli / puppet-elasticsearch

Elasticsearch Puppet module

Apache License 2.0

403 stars 478 forks source link

Add option to set private key type #1116

Open scornelissen85 opened 3 years ago

scornelissen85 commented 3 years ago

With this PR it's now possible to set the type of the private key. If, for example, an EC private key is used, it can set with value ec, which will be passed to java_ks. The new setting is optional, when not set the current default (rsa) is used. See https://github.com/puppetlabs/puppetlabs-java_ks/blob/main/REFERENCE.md#private_key_type

elasticmachine commented 3 years ago

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

vox-pupuli-tasks[bot] commented 2 years ago

Dear @sanderc85, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

phaedriel commented 2 months ago

Integrate with https://github.com/voxpupuli/puppet-elasticsearch/pull/1186