search

voxpupuli / puppet-elasticsearch

Elasticsearch Puppet module
Apache License 2.0
404 stars 479 forks source link

why was log4j2.properties.erb configuration commented ? #1200

Open alexfouche opened 12 months ago

alexfouche commented 12 months ago

How to reproduce (e.g Puppet code you use)

Set Elasticsearch logging options

    class { 'elasticsearch':
        file_rolling_type             => 'rollingFile',
        rolling_file_max_backup_index => 14,
        rolling_file_max_file_size    => '256MB',

What are you seeing

/etc/elasticsearch/log4j2.properties is not modified

What behaviour did you expect instead

/etc/elasticsearch/log4j2.properties to be modified

Question

Why was templating the log4j2.properties been disabled ? The block is completely commented in manifests/config.pp It seems to come from commit https://github.com/voxpupuli/puppet-elasticsearch/commit/67a07201d2e0837444ddebdbfc0fd3c43ca906eb

Why ?

Currently the Puppet module seems to allow no way to configure Elasticsearch logging

bmagistro commented 12 months ago

Looks like #1185 tries to bring back managing this file but also not sure why that was removed. This was very unexpected when upgrading and does not appear to break anything when actually using the module. If it was just for tests maybe those should have been reviewed versus breaking/significantly altering how the application is configured....