search

voxpupuli / puppet-elasticsearch

Elasticsearch Puppet module
Apache License 2.0
404 stars 479 forks source link

(#1203) Fix lib directory and file permissions #1204

Closed ttousai closed 8 months ago

ttousai commented 8 months ago

Pull Request (PR) description

This PR fixes an issue where puppet-elasticsearch changes the file mode of files in /usr/share/elasticsearch/lib every time Elasticsearch is upgraded with Apt. This is both unnecessary and undesirable.

From this commit , the intention was to fix the permission on the directory, but it is now changing the file mode of all the files in the directory as well.

From tests it is alright to set the file mode on the directory to 0644 as Puppet does the right thing setting the directory mode to 0755, irrespective of the umask value, while setting the file mode to 0644 as expected.

This Pull Request (PR) fixes the following issues

Fixes #1203

ttousai commented 8 months ago

The lib directory contains (so far) only jar files so I don't foresee a problem with making that directory readable by all system users.

ttousai commented 8 months ago

@smortex it looks like there is a problem with the CI / Puppet /7 - Ubuntu 20.04 (pull_request) check. I don't think it is related to my PR.

smortex commented 8 months ago

The lib directory contains (so far) only jar files so I don't foresee a problem with making that directory readable by all system users.

I read too fast and though it was the config directory.

@smortex it looks like there is a problem with the CI / Puppet /7 - Ubuntu 20.04 (pull_request) check. I don't think it is related to my PR.

Maybe the CI failure is a transient one, I re-triggered it.

smortex commented 8 months ago

Maybe the CI failure is a transient one, I re-triggered it.

Looks good now ;-) This feel safe to me.