voxpupuli / puppet-elasticsearch

Elasticsearch Puppet module
Apache License 2.0
404 stars 479 forks source link

stdlib v9 support, use namespaced stdlib functions #1208

Closed ggabijaa closed 4 months ago

ggabijaa commented 7 months ago

Pull Request (PR) description

Added Stdlib v9 support Added Puppet v8 support

This Pull Request (PR) fixes the following issues

Fixes https://github.com/voxpupuli/puppet-elasticsearch/issues/1201

ldaneliukas commented 6 months ago

@smortex any updates on this PR?

td-adc commented 4 months ago

Any updates/progress on this?

h-haaks commented 4 months ago

@ggabijaa could you please rebase against voxpupuli:master so that it is ready for merge once the current changes on master is released?

h-haaks commented 4 months ago

Rename PR and squash commits to something like 'Use namespaced stdlib functions'?

h-haaks commented 4 months ago

@ggabijaa please have a look at #1217 We could either merge that or you need to remove the stdlib dependency from metatdata.yaml and clean up your commits.

h-haaks commented 4 months ago

Thanks for your effort on this @ggabijaa. As I'm eager to get a new release out I decided to merge my PR and close this one.