search

voxpupuli / puppet-elasticsearch

Elasticsearch Puppet module
Apache License 2.0
403 stars 478 forks source link

Non-Instance Specific Installation Paramaters #879

Open Merakel opened 7 years ago

Merakel commented 7 years ago

Feature Description

As far as I can tell, there is no way to use this module to install elasticsearch without getting the instance specific configuration changes that come with it. A setting that allows ES to be installed to the default paths, /etc/elasticsearch instead of /etc/elasticsearch/<instance_name> and keep the service name as elasticsearch would be great. The way it's setup currently works fine for elastic specific functionality, but it makes it more difficult to configure independent monitoring tools in additional to increasing the amount of environmental knowledge admins require for troubleshooting.

tylerjl commented 6 years ago

This comes up occasionally, and the main hurdle is that it becomes really tricky to support both in the module - unifying how instances are controlled via elasticsearch::instance means there's only one code path to controlling how instances are managed.

With that being said, I don't think there's any reason to reject a change to the module that does this in a reasonable way. For many users a single instance is all they need, and the overhead of explicitly managing instances probably isn't necessary for them. The biggest question is which mode is default (either managing a single instance or multiple) and if the default changes, it'll need to go into a major release since it'll be a big change.

From my perspective this isn't a super-high priority item since there are other important features that need to get rolled out, but PRs are always welcome.

Merakel commented 6 years ago

I assumed that would be the case. I've started looking at doing it myself already. If I have questions about the automated testing is there a good place to ask those?

tylerjl commented 6 years ago

Sure, either here or on https://discuss.elastic.co/ (I'm leothrix on the elasticsearch channel on freenode) as well, whichever works for you. I'd probably prefer GitHub first since it'll be more easy to discover for others developing on the module who may have questions.