voxpupuli / puppet-epel

Setup/configure EPEL (extra repository for enterprise linux) with Puppet
Apache License 2.0
41 stars 95 forks source link

Add username/password params for each yumrepo #123

Closed cdenneen closed 3 years ago

cdenneen commented 3 years ago

Added username/password params for each yumrepo with defaults set to undef

TuningYourCode commented 3 years ago

Hi @cdenneen, could you please add test cases for this new feature? Without tests future refactoring or even new features could break this feature and nobody likes that :)

cdenneen commented 3 years ago

@TuningYourCode I can probably put something together but none of the other defaulted with undef "sslclientkey", "sslclientcert", "includepkgs", "exlucde" have any tests so wasn't sure since it doesn't change any default behaviors and is utilizing the default username and password of the yumrepo resource type.